Thread (3 messages) 3 messages, 3 authors, 2008-10-20

linux-next: vfs tree build failure

From: Stephen Rothwell <hidden>
Date: 2008-10-20 06:18:35
Subsystem: filesystems (vfs and infrastructure), the rest, xfs filesystem · Maintainers: Alexander Viro, Christian Brauner, Linus Torvalds, Carlos Maiolino

Hi Al,

Today's linux-next build (powerpc ppc64_defconfig) failed like this:

fs/xfs/linux-2.6/xfs_export.c: In function 'xfs_fs_get_parent':
fs/xfs/linux-2.6/xfs_export.c:201: error: incompatible type for argument 1 of 'd_obtain_alias'

Due to commit 8ee6b8fff20962d17a008e230006e48c7f79ade4 ("[PATCH] switch
all filesystems over to d_obtain_alias") from the vfs tree interacting
with commit 7836dda725873a5ce05d216295a452f16ccaab72 ("[XFS] Combine the
XFS and Linux inodes") from the xfs tree.

I must admit I am wondering why I am only seeing this error at this late
stage (the xfs commit is dated October 17) ...

I fixed it up by applying the following patch (which may be incorrect).
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

From: Stephen Rothwell <redacted>
Date: Mon, 20 Oct 2008 17:16:00 +1100
Subject: [PATCH] vfs/xfs: fallout from i_vnode change

Signed-off-by: Stephen Rothwell <redacted>
---
 fs/xfs/linux-2.6/xfs_export.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/xfs/linux-2.6/xfs_export.c b/fs/xfs/linux-2.6/xfs_export.c
index 263027f..dd71e86 100644
--- a/fs/xfs/linux-2.6/xfs_export.c
+++ b/fs/xfs/linux-2.6/xfs_export.c
@@ -198,7 +198,7 @@ xfs_fs_get_parent(
 	if (unlikely(error))
 		return ERR_PTR(-error);
 
-	return d_obtain_alias(cip->i_vnode);
+	return d_obtain_alias(&cip->i_vnode);
 }
 
 const struct export_operations xfs_export_operations = {
-- 
1.5.6.5
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help