Thread (3 messages) 3 messages, 2 authors, 2008-09-18

Re: linux-next: Tree for September 18

From: Andrew Morton <akpm@linux-foundation.org>
Date: 2008-09-18 22:21:25
Also in: lkml

On Thu, 18 Sep 2008 17:41:08 +1000
Stephen Rothwell [off-list ref] wrote:
I have created today's linux-next tree at
git://git.kernel.org/pub/scm/linux/kernel/git/sfr/linux-next.git
(patches at
http://www.kernel.org/pub/linux/kernel/people/sfr/linux-next/)
Anyone using this kernel shold apply this x86 fix:
--- a/include/linux/uaccess.h~uaccess-fix-parameters-inversion-for-__copy_from_user_inatomic
+++ a/include/linux/uaccess.h
@@ -78,7 +78,7 @@ static inline unsigned long __copy_from_
 							\
 		set_fs(KERNEL_DS);			\
 		pagefault_disable();			\
-		ret = __copy_from_user_inatomic((__force typeof(retval) __user *)(addr), &(retval), sizeof(retval));		\
+		ret = __copy_from_user_inatomic(&(retval), (__force typeof(retval) __user *)(addr), sizeof(retval));		\
 		pagefault_enable();			\
 		set_fs(old_fs);				\
 		ret;					\
_

to prevent a storm of warnings like

[   58.694606] SLAB: cache with size 16384 has lost its name
[   58.694773] SLAB: cache with size 8192 has lost its name
[   58.694940] SLAB: cache with size 8192 has lost its name
[   58.695101] SLAB: cache with size 4096 has lost its name
[   58.695260] SLAB: cache with size 4096 has lost its name
[   58.695418] SLAB: cache with size 2048 has lost its name

plus probably other more nasty things.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help