Thread (13 messages) 13 messages, 10 authors, 2008-08-20

Re: [PATCH next-20080819] drivers/usb/atm: Fix non-existing warn()

From: Greg KH <hidden>
Date: 2008-08-19 20:08:59

On Tue, Aug 19, 2008 at 01:28:48PM +0200, Takashi Iwai wrote:
quoted hunk ↗ jump to hunk
Fix the die-hard warn() in drivers/usb/atm/usbatm.h that caused a
build error.

Signed-off-by: Takashi Iwai <redacted>
---
diff --git a/drivers/usb/atm/usbatm.h b/drivers/usb/atm/usbatm.h
index e6887c6..714dc14 100644
--- a/drivers/usb/atm/usbatm.h
+++ b/drivers/usb/atm/usbatm.h
@@ -42,7 +42,7 @@
 #ifdef DEBUG
 #define UDSL_ASSERT(x)	BUG_ON(!(x))
 #else
-#define UDSL_ASSERT(x)	do { if (!(x)) warn("failed assertion '%s' at line %d", __stringify(x), __LINE__); } while(0)
+#define UDSL_ASSERT(x)	do { if (!(x)) pr_warning("failed assertion '%s' at line %d", __stringify(x), __LINE__); } while(0)
 #endif
 
 #define usb_err(instance, format, arg...)	\
Ah, sorry about that, I don't see how I missed it, I'll go fix this up.

Oh, you forgot the '\n' as well, I'll just convert this to a standard
printk() so everyone konws what is happening...

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help