Thread (8 messages) flat view 8 messages, 2 authors, 1h ago

Re: [PATCH v3 0/3] Bring includes in linux/kmod.h up to date

From: Petr Pavlu <petr.pavlu@suse.com>
Date: 2026-09-22 09:58:23
Also in: bridge, cgroups, dri-devel, driver-core, keyrings, linux-acpi, linux-block, linux-edac, linux-fbdev, linux-fsdevel, linux-nfs, linux-pm, linux-security-module, linuxppc-dev, lkml, netdev, ocfs2-devel

On 9/11/26 4:46 PM, Petr Pavlu wrote:
The usermode helper declarations were previously provided by linux/kmod.h
but commit c1f3fa2a4fde ("kmod: split off umh headers into its own file")
moved them to linux/umh.h in 2017. Add explicit includes of linux/umh.h to
files that use usermode helpers and remove linux/kmod.h where it is no
longer needed.

Also add a missing include of linux/sysctl.h to kernel/time/jiffies.c.

Finally, clean up linux/kmod.h so that it includes only the headers that it
actually requires, importantly removing the compat linux/umh.h include.

This cleanup is motivated by trying to reduce the preprocessed size of
linux/module.h, which includes linux/kmod.h. linux/module.h appears in
roughly 15k #include directives across the kernel. This makes it a "hot"
header, so it should avoid pulling in unnecessary definitions. Note that
this series doesn't immediately improve the situation, since most of the
files included by linux/kmod.h are, for now, also included by
linux/module.h through other paths.

Apologies for the wide distribution. Acked-bys are appreciated.
I've queued the series on modules-next for 7.4-rc1.

-- 
Thanks,
Petr
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help