Thread (56 messages) 56 messages, 3 authors, 2026-09-11

Re: [PATCH v9 27/39] dyndbg: check DYNAMIC_DEBUG_CLASSMAP_{DEFINE,USE_} args at compile-time

flat view

From: sashiko-bot@kernel.org
Date: 2026-09-09 01:07:50
Also in: dri-devel

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Typo in the commit message regarding the test macro `DD_MACRO_ARGCHECK`.
--

commit f1639b2e981e61be970216e485857e63c7d27ba2
Author: Jim Cromie [off-list ref]

dyndbg: check DYNAMIC_DEBUG_CLASSMAP_{DEFINE,USE_} args at compile-time

This commit adds compile-time checks for dynamic debug classmap macros to
prevent simple misuses. It validates base ranges, array sizes, and map types,
issuing obvious errors during compilation if violated.
Several bad examples are ifdef DDD_MACRO_ARGCHECK qualified in
test_dynamic_debug_submod.c and will fail compilation if enabled.
[Severity: Low]
This isn't a bug, but is there a typo in the commit message here?

The code in lib/test_dynamic_debug.c actually checks for DD_MACRO_ARGCHECK
instead of DDD_MACRO_ARGCHECK.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260908-dd-cmap-part2-clean-v9-0-3a3f621f4a10@gmail.com?part=27
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help