Re: [PATCH v8 43/43] selftests/dynamic_debug: Prime params module with +p in FT_comma_terminators
From: sashiko-bot@kernel.org
Date: 2026-09-05 18:27:35
Also in:
dri-devel
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] Replacing `module params =_` with `+p` removes the guarantee of a clean initial state, making the test brittle and susceptible to failures if run out of order or if prior tests leave a dirty state. -- commit 6253b17c937a384cba6edea98690f6a2ac1a30bb Author: Jim Cromie [off-list ref] selftests/dynamic_debug: Prime params module with +p in FT_comma_terminators This commit alters the test initialization in FT_comma_terminators from clearing flags to appending the 'p' flag to avoid a zero-length diff in the next command. It also updates the expected fingerprint for the test.
quoted hunk ↗ jump to hunk
diff --git a/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh b/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh index eeb5018d6f82c..d581b4e1cc80c 100755 --- a/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh +++ b/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh@@ -479,7 +479,7 @@ function FT_comma_terminators { echo "SKIP - test requires params, which is a builtin module" return fi - ddcmd "module params =_" + ddcmd "module params +p"
[Severity: Medium] Does replacing the absolute assignment =_ with the relative modifier +p remove the guarantee of a clean initial state for this test? If the dynamic debug flags for kernel/params.c are not completely empty before FT_comma_terminators runs, +p will append p to any residual flags (resulting in a state like pmf). When the subsequent command (ddcmd "module,params,=_") clears all flags, the resulting diff will include the removal of those unknown residual flags. Will this cause a fingerprint mismatch against the expected 3dbf... string and fail the test suite if tests are run out of order or if a prior test leaves a dirty state? [ ... ] -- Sashiko AI review · https://sashiko.dev/#/patchset/20260905-dd-cmap-part2-clean-v8-0-a4cc0674f6fd@gmail.com?part=43