Re: [PATCH v4 11/25] dyndbg-API: remove DD_CLASS_TYPE_(DISJOINT|LEVEL)_NAMES and code
From: sashiko-bot@kernel.org
Date: 2026-06-02 23:00:58
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Kernel-doc for DECLARE_DYNDBG_CLASSMAP incorrectly references `struct _ddebug_class_map`. -- commit 047a6407ea6feae6857cc7d6870594191a931c7d Author: Jim Cromie [off-list ref] dyndbg-API: remove DD_CLASS_TYPE_(DISJOINT|LEVEL)_NAMES and code This commit removes the unused DD_CLASS_TYPE_DISJOINT_NAMES and DD_CLASS_TYPE_LEVEL_NAMES classmap types to simplify the dynamic debug API. It also renames enum class_map_type to enum ddebug_class_map_type.
quoted hunk ↗ jump to hunk
diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h --- a/include/linux/dynamic_debug.h +++ b/include/linux/dynamic_debug.h
[ ... ]
quoted hunk ↗ jump to hunk
@@ -119,8 +108,8 @@ struct ddebug_class_param { /** * DECLARE_DYNDBG_CLASSMAP - declare classnames known by a module - * @_var: a struct ddebug_class_map, passed to module_param_cb - * @_type: enum class_map_type, chooses bits/verbose, numeric/symbolic + * @_var: a struct _ddebug_class_map, passed to module_param_cb
[Severity: Low] This isn't a bug, but is this change to struct _ddebug_class_map intentional? The DECLARE_DYNDBG_CLASSMAP macro instantiates a struct ddebug_class_map without the leading underscore, so this appears to be a typo introduced in the kernel-doc comment.
+ * @_maptype: enum ddebug_class_map_type, chooses bits/verbose * @_base: offset of 1st class-name. splits .class_id space * @classes: class-names used to control class'd prdbgs */
-- Sashiko AI review · https://sashiko.dev/#/patchset/20260602-dd-maint-2-v4-0-19a1445585a8@gmail.com?part=11