Re: [PATCH v2 11/24] dyndbg-API: remove DD_CLASS_TYPE_(DISJOINT|LEVEL)_NAMES and code
From: sashiko-bot@kernel.org
Date: 2026-05-23 07:33:47
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The documentation comment for DECLARE_DYNDBG_CLASSMAP references the old enum and outdated symbolic features. -- commit 71dcc2d5d3240e498bff39bb8fa71e77409d1cbd Author: Jim Cromie [off-list ref] dyndbg-API: remove DD_CLASS_TYPE_(DISJOINT|LEVEL)_NAMES and code This commit removes the DD_CLASS_TYPE_DISJOINT_NAMES and DD_CLASS_TYPE_LEVEL_NAMES classmap types. It simplifies the API by removing support for symbolic class names in parameter inputs, which were primarily used for tests. It also renames the class_map_type enum to ddebug_class_map_type.
quoted hunk ↗ jump to hunk
diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h index a10adac8e8f00..aa45dcf36a448 100644 --- a/include/linux/dynamic_debug.h +++ b/include/linux/dynamic_debug.h@@ -59,27 +59,16 @@ struct _ddebug { #endif } __attribute__((aligned(8))); -enum class_map_type { +enum ddebug_class_map_type {
[Severity: Low] This isn't a bug, but should the kernel-doc comment for DECLARE_DYNDBG_CLASSMAP be updated to reflect this new enum name and the removed symbolic support? It still refers to the old enum class_map_type and mentions numeric/symbolic choices: /** * DECLARE_DYNDBG_CLASSMAP - declare classnames known by a module * @_var: a struct ddebug_class_map, passed to module_param_cb * @_type: enum class_map_type, chooses bits/verbose, numeric/symbolic * @_base: offset of 1st class-name. splits .class_id space * @classes: class-names used to control class'd prdbgs */
DD_CLASS_TYPE_DISJOINT_BITS,
[ ... ] -- Sashiko AI review · https://sashiko.dev/#/patchset/20260523-dd-maint-2-v2-0-b937312aa083@gmail.com?part=11