Re: [PATCH] module: remove MODULE_VERSION()

On Mon, Mar 16, 2026 at 01:58:41AM -0700, Christoph Hellwig wrote:

On Sat, Mar 14, 2026 at 11:22:22AM +0100, Christophe Leroy (CS GROUP) wrote:

quoted

quoted

Sami just pointed out to me off-list that maybe I should also drop the
srcversion stuff too.  I'll gladly do that too, does anyone know if
anyone even uses that anymore?

If I understand correctly the text in kernel/module/Kconfig, srcversion is
added only for modules which contain a MODULE_VERSION.

So as you drop MODULE_VERSION, srcversion becomes completely useless doesn't
it ?

Looks like it.

Looking at modpost, srcversions are added to all modules if
MODULE_SRCVERSION_ALL is enabled, whether they have MODULE_VERSION or
not. Doesn't mean it's not completely useless, of course.

Sami