Re: [PATCH v7 3/6] rust: str: implement `AsRef<BStr>` for `[u8]` and `BStr`

On 21 Feb 2025, at 13:01, Daniel Almeida [off-list ref] wrote:

quoted

On 18 Feb 2025, at 10:00, Andreas Hindborg [off-list ref] wrote:

Implement `AsRef<BStr>` for `[u8]` and `BStr` so these can be used
interchangeably for operations on `BStr`.

Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>
---
rust/kernel/str.rs | 12 ++++++++++++
1 file changed, 12 insertions(+)

diff --git a/rust/kernel/str.rs b/rust/kernel/str.rs
index ba6b1a5c4f99d..c6bd2c69543dc 100644
--- a/rust/kernel/str.rs
+++ b/rust/kernel/str.rs

@@ -125,6 +125,18 @@ fn index(&self, index: Idx) -> &Self::Output {
   }

}

+impl AsRef<BStr> for [u8] {
+    fn as_ref(&self) -> &BStr {
+        BStr::from_bytes(self)
+    }
+}
+
+impl AsRef<BStr> for BStr {
+    fn as_ref(&self) -> &BStr {
+        self
+    }
+}

Why do you need this last one?

I see that this is used by the following patch.

quoted

+
/// Creates a new [`BStr`] from a string literal.
///
/// `b_str!` converts the supplied string literal to byte string, so non-ASCII

-- 
2.47.0

Reviewed-by: Daniel Almeida <daniel.almeida@collabora.com>