Re: [PATCH v2] init: staging: Fix missing warning/taint on builtin code
From: Dan Carpenter <hidden>
Date: 2024-07-05 14:25:17
Also in:
linux-staging, lkml
On Thu, Jul 04, 2024 at 09:20:49PM -0300, Ágatha Isabelle Chris Moreira Guedes wrote:
quoted hunk ↗ jump to hunk
+#ifdef CONFIG_STAGING +/** + * staging_init_taint() - We need to taint the kernel whenever staging code + * is initialized (from built-in drivers) or loaded (as modules) and issue + * a warning the first time it happens. + */ +void staging_taint(const char *code_id, bool module) +{ + char *code_type = module ? "module" : "builtin driver"; + + pr_warn("%s %s: The kernel contains code from staging directory" + ", the quality is unknown, you have been warned.\n",
I wasn't going to say anything but since you're resending anyway, please, don't break the line like this so it starts with a comma. The comma can go on the line before. But if it couldn't then we would move the whole word "directory," to the next line. regards, dan carpenter