Re: [PATCH v5 24/37] rust: Add a rust helper for krealloc()

[PATCH v5 00/37] Memory allocation profiling · Suren Baghdasaryan <surenb@google.com> · 2024-03-06
[PATCH v5 01/37] fix missing vmalloc.h includes · Suren Baghdasaryan <surenb@google.com> · 2024-03-06
[PATCH v5 02/37] asm-generic/io.h: Kill vmalloc.h dependency · Suren Baghdasaryan <surenb@google.com> · 2024-03-06
[PATCH v5 03/37] mm/slub: Mark slab_free_freelist_hook() __always_inline · Suren Baghdasaryan <surenb@google.com> · 2024-03-06
Re: [PATCH v5 03/37] mm/slub: Mark slab_free_freelist_hook() __always_inline · Vlastimil Babka <hidden> · 2024-03-13
[PATCH v5 04/37] scripts/kallysms: Always include __start and __stop symbols · Suren Baghdasaryan <surenb@google.com> · 2024-03-06
[PATCH v5 05/37] fs: Convert alloc_inode_sb() to a macro · Suren Baghdasaryan <surenb@google.com> · 2024-03-06
[PATCH v5 06/37] mm: introduce slabobj_ext to support slab object extensions · Suren Baghdasaryan <surenb@google.com> · 2024-03-06
Re: [PATCH v5 06/37] mm: introduce slabobj_ext to support slab object extensions · Vlastimil Babka <hidden> · 2024-03-13
[PATCH v5 07/37] mm: introduce __GFP_NO_OBJ_EXT flag to selectively prevent slabobj_ext creation · Suren Baghdasaryan <surenb@google.com> · 2024-03-06
[PATCH v5 08/37] mm/slab: introduce SLAB_NO_OBJ_EXT to avoid obj_ext creation · Suren Baghdasaryan <surenb@google.com> · 2024-03-06
[PATCH v5 09/37] slab: objext: introduce objext_flags as extension to page_memcg_data_flags · Suren Baghdasaryan <surenb@google.com> · 2024-03-06
[PATCH v5 10/37] lib: code tagging framework · Suren Baghdasaryan <surenb@google.com> · 2024-03-06
[PATCH v5 11/37] lib: code tagging module support · Suren Baghdasaryan <surenb@google.com> · 2024-03-06
[PATCH v5 12/37] lib: prevent module unloading if memory is not freed · Suren Baghdasaryan <surenb@google.com> · 2024-03-06
Re: [PATCH v5 12/37] lib: prevent module unloading if memory is not freed · Luis Chamberlain <mcgrof@kernel.org> · 2024-03-12
Re: [PATCH v5 12/37] lib: prevent module unloading if memory is not freed · Suren Baghdasaryan <surenb@google.com> · 2024-03-12
[PATCH v5 13/37] lib: add allocation tagging support for memory allocation profiling · Suren Baghdasaryan <surenb@google.com> · 2024-03-06
[PATCH v5 14/37] lib: introduce support for page allocation tagging · Suren Baghdasaryan <surenb@google.com> · 2024-03-06
Re: [PATCH v5 14/37] lib: introduce support for page allocation tagging · Matthew Wilcox <willy@infradead.org> · 2024-03-15
Re: [PATCH v5 14/37] lib: introduce support for page allocation tagging · Suren Baghdasaryan <surenb@google.com> · 2024-03-15
[PATCH v5 15/37] lib: introduce early boot parameter to avoid page_ext memory overhead · Suren Baghdasaryan <surenb@google.com> · 2024-03-06
Re: [PATCH v5 15/37] lib: introduce early boot parameter to avoid page_ext memory overhead · Vlastimil Babka <hidden> · 2024-03-13
[PATCH v5 16/37] mm: percpu: increase PERCPU_MODULE_RESERVE to accommodate allocation tags · Suren Baghdasaryan <surenb@google.com> · 2024-03-06
[PATCH v5 17/37] change alloc_pages name in dma_map_ops to avoid name conflicts · Suren Baghdasaryan <surenb@google.com> · 2024-03-06
[PATCH v5 18/37] mm: enable page allocation tagging · Suren Baghdasaryan <surenb@google.com> · 2024-03-06
[PATCH v5 19/37] mm: create new codetag references during page splitting · Suren Baghdasaryan <surenb@google.com> · 2024-03-06
[PATCH v5 20/37] mm: fix non-compound multi-order memory accounting in __free_pages · Suren Baghdasaryan <surenb@google.com> · 2024-03-06
Re: [PATCH v5 20/37] mm: fix non-compound multi-order memory accounting in __free_pages · Vlastimil Babka <hidden> · 2024-03-13
Re: [PATCH v5 20/37] mm: fix non-compound multi-order memory accounting in __free_pages · Matthew Wilcox <willy@infradead.org> · 2024-03-13
Re: [PATCH v5 20/37] mm: fix non-compound multi-order memory accounting in __free_pages · Suren Baghdasaryan <surenb@google.com> · 2024-03-13
[PATCH v5 21/37] mm/page_ext: enable early_page_ext when CONFIG_MEM_ALLOC_PROFILING_DEBUG=y · Suren Baghdasaryan <surenb@google.com> · 2024-03-06
[PATCH v5 22/37] lib: add codetag reference into slabobj_ext · Suren Baghdasaryan <surenb@google.com> · 2024-03-06
[PATCH v5 23/37] mm/slab: add allocation accounting into slab allocation and free paths · Suren Baghdasaryan <surenb@google.com> · 2024-03-06
Re: [PATCH v5 23/37] mm/slab: add allocation accounting into slab allocation and free paths · Vlastimil Babka <hidden> · 2024-03-15
Re: [PATCH v5 23/37] mm/slab: add allocation accounting into slab allocation and free paths · Suren Baghdasaryan <surenb@google.com> · 2024-03-15
Re: [PATCH v5 23/37] mm/slab: add allocation accounting into slab allocation and free paths · Vlastimil Babka <hidden> · 2024-03-15
Re: [PATCH v5 23/37] mm/slab: add allocation accounting into slab allocation and free paths · Suren Baghdasaryan <surenb@google.com> · 2024-03-15
[PATCH v5 24/37] rust: Add a rust helper for krealloc() · Suren Baghdasaryan <surenb@google.com> · 2024-03-06
Re: [PATCH v5 24/37] rust: Add a rust helper for krealloc() · Miguel Ojeda <hidden> · 2024-03-08
[PATCH v5 25/37] mm/slab: enable slab allocation tagging for kmalloc and friends · Suren Baghdasaryan <surenb@google.com> · 2024-03-06
[PATCH v5 26/37] mempool: Hook up to memory allocation profiling · Suren Baghdasaryan <surenb@google.com> · 2024-03-06
[PATCH v5 27/37] mm: percpu: Introduce pcpuobj_ext · Suren Baghdasaryan <surenb@google.com> · 2024-03-06
[PATCH v5 28/37] mm: percpu: Add codetag reference into pcpuobj_ext · Suren Baghdasaryan <surenb@google.com> · 2024-03-06
[PATCH v5 29/37] mm: percpu: enable per-cpu allocation tagging · Suren Baghdasaryan <surenb@google.com> · 2024-03-06
[PATCH v5 30/37] mm: vmalloc: Enable memory allocation profiling · Suren Baghdasaryan <surenb@google.com> · 2024-03-06
[PATCH v5 31/37] rhashtable: Plumb through alloc tag · Suren Baghdasaryan <surenb@google.com> · 2024-03-06
[PATCH v5 32/37] lib: add memory allocations report in show_mem() · Suren Baghdasaryan <surenb@google.com> · 2024-03-06
[PATCH v5 33/37] codetag: debug: skip objext checking when it's for objext itself · Suren Baghdasaryan <surenb@google.com> · 2024-03-06
[PATCH v5 34/37] codetag: debug: mark codetags for reserved pages as empty · Suren Baghdasaryan <surenb@google.com> · 2024-03-06
[PATCH v5 35/37] codetag: debug: introduce OBJEXTS_ALLOC_FAIL to mark failed slab_ext allocations · Suren Baghdasaryan <surenb@google.com> · 2024-03-06
[PATCH v5 36/37] MAINTAINERS: Add entries for code tagging and memory allocation profiling · Suren Baghdasaryan <surenb@google.com> · 2024-03-06
[PATCH v5 37/37] memprofiling: Documentation · Suren Baghdasaryan <surenb@google.com> · 2024-03-06
Re: [PATCH v5 37/37] memprofiling: Documentation · Randy Dunlap <hidden> · 2024-03-07
Re: [PATCH v5 37/37] memprofiling: Documentation · Suren Baghdasaryan <surenb@google.com> · 2024-03-07
Re: [PATCH v5 37/37] memprofiling: Documentation · Randy Dunlap <hidden> · 2024-03-07
Re: [PATCH v5 37/37] memprofiling: Documentation · Kent Overstreet <kent.overstreet@linux.dev> · 2024-03-07
Re: [PATCH v5 37/37] memprofiling: Documentation · Randy Dunlap <hidden> · 2024-03-07
Re: [PATCH v5 37/37] memprofiling: Documentation · John Hubbard <jhubbard@nvidia.com> · 2024-03-07
Re: [PATCH v5 37/37] memprofiling: Documentation · Randy Dunlap <hidden> · 2024-03-07

From: Miguel Ojeda <hidden>
Date: 2024-03-08 15:23:44
Also in: cgroups, linux-arch, linux-doc, linux-fsdevel, linux-iommu, linux-mm, lkml, rust-for-linux

On Wed, Mar 6, 2024 at 7:26 PM Suren Baghdasaryan [off-list ref] wrote:

+void * __must_check rust_helper_krealloc(const void *objp, size_t new_size,
+                                        gfp_t flags) __realloc_size(2)

The `__realloc_size(2)` should be placed earlier, i.e. this triggers:

rust/helpers.c:162:20: error: GCC does not allow '__alloc_size__'
attribute in this position on a function definition [-Wgcc-compat]

With that fixed:

Acked-by: Miguel Ojeda <ojeda@kernel.org>

Cheers,
Miguel

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help