Re: [PATCH v1] module.h: define __symbol_get_gpl() as a regular __symbol_get()
From: Luis Chamberlain <mcgrof@kernel.org>
Date: 2024-03-12 22:25:28
Also in:
lkml
From: Luis Chamberlain <mcgrof@kernel.org>
Date: 2024-03-12 22:25:28
Also in:
lkml
On Tue, Feb 13, 2024 at 02:10:45PM +0300, Andrew Kanner wrote:
On Thu, Feb 01, 2024 at 10:13:54AM -0800, Luis Chamberlain wrote:quoted
While you're at it, if you want to try it, you could see if you can improve the situation more by looking at symbol_get() users that remain and seeing if you can instead fix it with proper Kconfig dependency and at build time. Then we can just remove it as well. LuisSorry for the late reply. Luis, can you give more details of your idea? I re-read it once, then came back and still don't understand. I see that there are ~10 users for symbol_get() currently. Do you want to stringify symbol names at build time to completely remove symbol_get() from module.h? Correct me if I'm wrong since using of a fuction which is not declared anywhere sounds confusing.
As an example look at the code and see if there's a sensible way to make some calls built-in instead of part of the module, then the module can have a kconfig builtin option, that adds to the built-in code which means you don't need the symbol_get(). For some other pieces of code it may require other strategies. Luis