Thread (208 messages) 208 messages, 21 authors, 2024-02-29

Re: [PATCH v3 23/35] mm/slub: Mark slab_free_freelist_hook() __always_inline

From: Vlastimil Babka <hidden>
Date: 2024-02-14 15:13:59
Also in: cgroups, linux-arch, linux-doc, linux-fsdevel, linux-iommu, linux-mm, lkml

On 2/13/24 03:08, Kent Overstreet wrote:
On Mon, Feb 12, 2024 at 04:31:14PM -0800, Kees Cook wrote:
quoted
On Mon, Feb 12, 2024 at 01:39:09PM -0800, Suren Baghdasaryan wrote:
quoted
From: Kent Overstreet <kent.overstreet@linux.dev>

It seems we need to be more forceful with the compiler on this one.
Sure, but why?
Wasn't getting inlined without it, and that's one we do want inlined -
it's only called in one place.
It would be better to mention this in the changelog so it's clear this is
for performance and not e.g. needed for the code tagging to work as expected.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help