On Thu, Sep 21, 2023 at 03:30:46PM -0700, Song Liu wrote:

On Mon, Sep 18, 2023 at 12:31 AM Mike Rapoport [off-list ref] wrote:

quoted

[...]

quoted

@@ -135,5 +138,13 @@ struct execmem_params __init *execmem_arch_params(void)

        range->pgprot = prot;

+       execmem_params.ranges[EXECMEM_KPROBES].start = VMALLOC_START;
+       execmem_params.ranges[EXECMEM_KPROBES].start = VMALLOC_END;

.end = VMALLOC_END.

Thanks, this should have been

	execmem_params.ranges[EXECMEM_KPROBES].start = range->start;
	execmem_params.ranges[EXECMEM_KPROBES].end = range->end;

where range points to the same range as EXECMEM_MODULE_TEXT.

 

Thanks,
Song

quoted

+
+       if (strict_module_rwx_enabled())
+               execmem_params.ranges[EXECMEM_KPROBES].pgprot = PAGE_KERNEL_ROX;
+       else
+               execmem_params.ranges[EXECMEM_KPROBES].pgprot = PAGE_KERNEL_EXEC;
+
        return &execmem_params;
 }
--
2.39.2

-- 
Sincerely yours,
Mike.