Re: [PATCH] media: dvb: symbol fixup for dvb_attach()

Em Fri, 8 Sep 2023 17:35:07 +0100
Greg Kroah-Hartman [off-list ref] escreveu:

On Fri, Sep 08, 2023 at 09:21:29AM -0700, Luis Chamberlain wrote:

quoted

On Fri, Sep 08, 2023 at 10:20:36AM +0100, Greg Kroah-Hartman wrote:  

quoted

In commit 9011e49d54dc ("modules: only allow symbol_get of
EXPORT_SYMBOL_GPL modules") the use of symbol_get is properly restricted
to GPL-only marked symbols.  This interacts oddly with the DVB logic
which only uses dvb_attach() to load the dvb driver which then uses
symbol_get().

Fix this up by properly marking all of the dvb_attach attach symbols as
EXPORT_SYMBOL_GPL().

Fixes: 9011e49d54dc ("modules: only allow symbol_get of EXPORT_SYMBOL_GPL modules")
Cc: stable <stable@kernel.org>
Reported-by: Stefan Lippers-Hollmann <redacted>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>
Cc: linux-media@vger.kernel.org
Cc: linux-modules@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
Luis, do you want to take this through your tree?  Or Mauro's?  Or I can
take it through mine, it should get to Linus soon as this is causing
regressions in his tree.  

You've done the work so it is up to you, whatever helps you expedite it
as it already hit stable. Feel free to take it through your tree.  

If you ack it, I can take it now through my tree and send it to Linus
tomorrow.

You can send it via your trees. So:

Acked-by: Mauro Carvalho Chehab <mchehab@kernel.org>

thanks,

greg k-h