Thread (1 message) 1 message, 1 author, 2023-03-20

Re: [PATCH 10/27] leds: remove MODULE_LICENSE in non-modules

From: Nick Alcock <hidden>
Date: 2023-03-20 13:06:32
Also in: linux-leds, lkml

On 3 Mar 2023, Lee Jones uttered the following:
On Fri, 24 Feb 2023, Nick Alcock wrote:
quoted
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.

So remove it in the files in this commit, none of which can be built as
modules.

Signed-off-by: Nick Alcock <redacted>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Pavel Machek <redacted>
Cc: Lee Jones <lee@kernel.org>
Cc: linux-leds@vger.kernel.org
---
 drivers/leds/leds-asic3.c | 1 -
 1 file changed, 1 deletion(-)
Mention the driver in the subject line please.
Sorry, the prefix-generation is all automated: we use whatever prefix is
most commonly used by all affected drivers in the subsystem and shared
by all of them. In this case, that was simply 'leds', apparently because
almost all things affecting this driver were treewide.

... which probably explains why the driver was removed in January and is
gone in -next, so I guess this one will go away shortly regardless.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help