Thread (6 messages) 6 messages, 5 authors, 2023-03-22

Re: [PATCH] module/decompress: Never use kunmap() for local un-mappings

From: Stephen Boyd <hidden>
Date: 2023-03-17 19:04:17
Also in: bpf, live-patching, lkml, llvm

Quoting Fabio M. De Francesco (2023-03-15 05:52:56)
Use kunmap_local() to unmap pages locally mapped with kmap_local_page().

kunmap_local() must be called on the kernel virtual address returned by
kmap_local_page(), differently from how we use kunmap() which instead
expects the mapped page as its argument.

In module_zstd_decompress() we currently map with kmap_local_page() and
unmap with kunmap(). This breaks the code and so it should be fixed.

Cc: Piotr Gorski <redacted>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: Stephen Boyd <redacted>
Cc: Ira Weiny <ira.weiny@intel.com>
Fixes: 169a58ad824d ("module/decompress: Support zstd in-kernel decompression")
Signed-off-by: Fabio M. De Francesco <redacted>
---
Reviewed-by: Stephen Boyd <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help