Re: [PATCH 01/27] gpio: remove MODULE_LICENSE in non-modules

From
Bartosz Golaszewski <hidden>
Date
2023-03-06 09:48:08
Also in
linux-arm-kernel, linux-gpio, lkml
Reply to
Nick Alcock, 2023-02-24
On Fri, Feb 24, 2023 at 4:08 PM Nick Alcock [off-list ref] wrote:
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.

So remove it in the files in this commit, none of which can be built as
modules.

Signed-off-by: Nick Alcock <redacted>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: <redacted>
Cc: <redacted>
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Linus Walleij <redacted>
Cc: Bartosz Golaszewski <redacted>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: <redacted>
Cc: <redacted>
---
Applied, thanks!

Bart
Thread (2 messages) 2 messages, 2 authors, last reply 2023-03-06
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help