Hi Nick,

On Fri, Mar 3, 2023 at 7:32 PM Nick Alcock [off-list ref] wrote:

On 3 Mar 2023, Geert Uytterhoeven told this:

quoted

On Thu, Mar 2, 2023 at 11:25 PM Nick Alcock [off-list ref] wrote:

quoted

--- a/drivers/bus/simple-pm-bus.c
+++ b/drivers/bus/simple-pm-bus.c

@@ -92,4 +92,3 @@ module_platform_driver(simple_pm_bus_driver);

 MODULE_DESCRIPTION("Simple Power-Managed Bus Driver");
 MODULE_AUTHOR("Geert Uytterhoeven <geert+renesas@glider.be>");
-MODULE_LICENSE("GPL v2");

Please do not remove this line as long as the file has no SPDX-License
tag.

I'll augment this patch with an SPDX addition, if you think that's OK,
which it sounds like you do. (MODULE_LICENSE has side effects these days
which a SPDX header does not, and those side effects are wrong for
things that cannot be modules.)

Yeah, simple-pm-bus should not be a module.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds