Re: [PATCH v2 0/2] dyndbg: let's use the module notifier callback

From
Jason Baron <jbaron@akamai.com>
Date
2023-02-28 20:29:21
Also in
lkml
Reply to
Luis Chamberlain, 2023-02-28

On 2/28/23 3:18 PM, Luis Chamberlain wrote:
On Tue, Feb 28, 2023 at 02:34:20PM -0500, Jason Baron wrote:
quoted
Hi,

Jim Cromie hit a BUG() while toggling jump label branches in a module
before they were properly initialized. This isn't currently an issue,
but will be as part of his pending classmap series. Seems like we
should covert to using module callback notifier for dynamic debug
anyways. First patch is just a cleanup.

Link: https://urldefense.com/v3/__https://lore.kernel.org/lkml/20230113193016.749791-21-jim.cromie@xxxxxxxxx/__;!!GjvTz_vk!RcYAOcwdnCTVPf9WgS4GmmVwClimlsK1BfnLrRh4Oxlf1fJeOfBHa7zgCXDFiV8gw3YCGIbcdiYG$

Thanks,

-Jason

v2:
-Fix: error: field 'dyndbg_info' has incomplete type
  Reported-by: kernel test robot [off-list ref]
  Link: https://urldefense.com/v3/__https://lore.kernel.org/oe-kbuild-all/202302190427.9iIK2NfJ-lkp@intel.com/__;!!GjvTz_vk!RcYAOcwdnCTVPf9WgS4GmmVwClimlsK1BfnLrRh4Oxlf1fJeOfBHa7zgCXDFiV8gw3YCGJKpcyr8$
-make ddebug_remove_module() static
Do you have tests to ensure no regressions have occurred? If so what
are they? If there are no tests, can you come up with some basic ones?

   Luis

Hi Luis,

Yes, I've run the test case that prompted this series here:

https://lore.kernel.org/lkml/20230125203743.564009-20-jim.cromie@gmail.com/ (local)

Note that this is for new functionality that Jim is working on and he plan to include this series when he re-posts his series. And thus I've added Jim's Tested-by: in patches 1 and 2.

There is also a 'test_dynamic_debug' module which I've run as follows:

# modprobe test_dynamic_debug dyndbg

And confirmed the appropriate prints to the log. This exercises the code paths that were changed here.

Thanks,

-Jason
Thread (12 messages) 12 messages, 4 authors, last reply 2023-03-09
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help