Re: [PATCH 12/27] mailbox: zynqmp-ipi: remove MODULE_LICENSE in non-modules

From
Michal Simek <michal.simek@amd.com>
Date
2023-02-27 11:52:24
Also in
linux-arm-kernel, lkml
Reply to
Nick Alcock, 2023-02-24

On 2/24/23 16:07, Nick Alcock wrote:
quoted hunk ↗ jump to hunk
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.

So remove it in the files in this commit, none of which can be built as
modules.

Signed-off-by: Nick Alcock <redacted>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: <redacted>
Cc: <redacted>
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Jassi Brar <jassisinghbrar@gmail.com>
Cc: Michal Simek <redacted>
Cc: <redacted>
---
  drivers/mailbox/zynqmp-ipi-mailbox.c | 1 -
  1 file changed, 1 deletion(-)
diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c b/drivers/mailbox/zynqmp-ipi-mailbox.c
index 12e004ff1a14..c4619d31477e 100644
--- a/drivers/mailbox/zynqmp-ipi-mailbox.c
+++ b/drivers/mailbox/zynqmp-ipi-mailbox.c
@@ -718,6 +718,5 @@ static void __exit zynqmp_ipi_exit(void)
  }
  module_exit(zynqmp_ipi_exit);

-MODULE_LICENSE("GPL v2");
  MODULE_DESCRIPTION("Xilinx ZynqMP IPI Mailbox driver");
  MODULE_AUTHOR("Xilinx Inc.");
--
2.39.1.268.g9de2f9a303
It is the same case as 24/27. Prefer to change Kconfig from bool to tristate.

Thanks,
Michal
Thread (2 messages) 2 messages, 2 authors, last reply 2023-02-27
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help