Thread (2 messages) 2 messages, 2 authors, 2023-02-27

Re: [PATCH 24/27] firmware: xilinx: remove MODULE_LICENSE in non-modules

From: Michal Simek <michal.simek@amd.com>
Date: 2023-02-27 11:51:27
Also in: linux-arm-kernel, lkml


On 2/24/23 16:08, Nick Alcock wrote:
quoted hunk ↗ jump to hunk
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.

So remove it in the files in this commit, none of which can be built as
modules.

Signed-off-by: Nick Alcock <redacted>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Srinivas Kandagatla <redacted>
Cc: Michal Simek <redacted>
Cc: linux-arm-kernel@lists.infradead.org
---
  drivers/nvmem/zynqmp_nvmem.c | 1 -
  1 file changed, 1 deletion(-)
diff --git a/drivers/nvmem/zynqmp_nvmem.c b/drivers/nvmem/zynqmp_nvmem.c
index e28d7b133e11..844c1d861dea 100644
--- a/drivers/nvmem/zynqmp_nvmem.c
+++ b/drivers/nvmem/zynqmp_nvmem.c
@@ -78,4 +78,3 @@ module_platform_driver(zynqmp_nvmem_driver);

  MODULE_AUTHOR("Michal Simek <michal.simek@xilinx.com>, Nava kishore Manne <navam@xilinx.com>");
  MODULE_DESCRIPTION("ZynqMP NVMEM driver");
-MODULE_LICENSE("GPL");
--
2.39.1.268.g9de2f9a303
I would prefer to fix this by changing Kconfig symbol from bool to tristate.

Thanks,
Michal
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help