Thread (3 messages) 3 messages, 3 authors, 2023-02-27

Re: [PATCH 27/27] lib: packing: remove MODULE_LICENSE in non-modules

From: Vladimir Oltean <olteanv@gmail.com>
Date: 2023-02-24 15:22:23
Also in: lkml, netdev

On Fri, Feb 24, 2023 at 03:08:11PM +0000, Nick Alcock wrote:
quoted hunk ↗ jump to hunk
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.

So remove it in the files in this commit, none of which can be built as
modules.

Signed-off-by: Nick Alcock <redacted>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Vladimir Oltean <olteanv@gmail.com>
Cc: netdev@vger.kernel.org
---
 lib/packing.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/lib/packing.c b/lib/packing.c
index a96169237ae6..3f656167c17e 100644
--- a/lib/packing.c
+++ b/lib/packing.c
@@ -198,5 +198,4 @@ int packing(void *pbuf, u64 *uval, int startbit, int endbit, size_t pbuflen,
 }
 EXPORT_SYMBOL(packing);
 
-MODULE_LICENSE("GPL v2");
 MODULE_DESCRIPTION("Generic bitfield packing and unpacking");
-- 
2.39.1.268.g9de2f9a303
Is this a bug fix? Does it need a Fixes: tag? How is it supposed to be
merged? lib/packing.c is maintained by netdev, and I believe that netdev
maintainers would prefer netdev patches to be submitted separately.

Note that I was copied only on this patch, I haven't read the cover
letter if that exists.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help