RE: [PATCH 18/27] kbuild, mfd: remove MODULE_LICENSE in non-modules
From: DLG Adam Ward <hidden>
Date: 2023-02-24 15:03:49
Also in:
lkml
Possibly related (same subject, not in this thread)
- 2023-03-01 · Re: [PATCH 18/27] kbuild, mfd: remove MODULE_LICENSE in non-modules · Lee Jones <lee@kernel.org>
- 2023-02-27 · Re: [PATCH 18/27] kbuild, mfd: remove MODULE_LICENSE in non-modules · Nick Alcock <hidden>
- 2023-02-23 · Re: [PATCH 18/27] kbuild, mfd: remove MODULE_LICENSE in non-modules · Lee Jones <lee@kernel.org>
- 2023-02-22 · RE: [PATCH 18/27] kbuild, mfd: remove MODULE_LICENSE in non-modules · DLG Adam Ward <hidden>
- 2023-02-22 · [PATCH 18/27] kbuild, mfd: remove MODULE_LICENSE in non-modules · Nick Alcock <hidden>
On 23/02/2023 19:25, Nick Alcock wrote:
quoted
Makes sense - but if you need to do a V2, would you mind removing the erroneous claim on DA9055 at the same time?
I don't know what this means. There are two references to DA9055 in this patch, both in context (not in modified lines), one in drivers/mfd/da9055-core.c, the other in rivers/mfd/da9055-i2c.c. To me these both seem likely to be DA9055-related. Are you saying that one of them isn't?
The comment was followed by this link - https://elixir.bootlin.com/linux/latest/source/drivers/mfd/Kconfig#L36 This files talks about the driver being a module, but, as you correctly point out, it is not. And never has been. So it is worth removing.