Re: [PATCH 12/27] kbuild, clk: remove MODULE_LICENSE in non-modules

From
Conor Dooley <conor.dooley@microchip.com>
Date
2023-02-22 12:41:58
Also in
linux-clk, lkml
Reply to
Nick Alcock, 2023-02-22
On Wed, Feb 22, 2023 at 12:14:38PM +0000, Nick Alcock wrote:
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.

So remove it in the files in this commit, none of which can be built as
modules.

Signed-off-by: Nick Alcock <redacted>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: <redacted>
Cc: <redacted>
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Michael Turquette <redacted>
Cc: Stephen Boyd <sboyd@kernel.org>
Cc: <redacted>
 drivers/clk/microchip/clk-mpfs-ccc.c | 1 -
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
And since there's no reason to have this split via the at91 tree:
Acked-by: Conor Dooley <conor.dooley@microchip.com>

Clearly there's a hole in my maintainers entry for this driver, I'll go
fix that.

Attachments

Thread (4 messages) 4 messages, 3 authors, last reply 2023-03-06
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help