Re: [PATCH 11/24] kbuild, soc: apple: apple-pmgr-pwrstate: remove MODULE_LICENSE in non-modules
flat view
From: Sven Peter <hidden>
Date: 2023-02-19 12:39:27
Also in:
asahi, linux-arm-kernel, lkml
On Fri, Feb 17, 2023, at 15:10, Nick Alcock wrote:
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <redacted>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Hector Martin <redacted>
Cc: Sven Peter <redacted>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: asahi@lists.linux.dev
Cc: linux-arm-kernel@lists.infradead.org
---Acked-by: Sven Peter <redacted> Sven
quoted hunk ↗ jump to hunk
drivers/soc/apple/apple-pmgr-pwrstate.c | 1 - 1 file changed, 1 deletion(-)diff --git a/drivers/soc/apple/apple-pmgr-pwrstate.cb/drivers/soc/apple/apple-pmgr-pwrstate.c index e1122288409a..2c15474c7b53 100644--- a/drivers/soc/apple/apple-pmgr-pwrstate.c +++ b/drivers/soc/apple/apple-pmgr-pwrstate.c@@ -319,6 +319,5 @@ static struct platform_driver apple_pmgr_ps_driver= { MODULE_AUTHOR("Hector Martin [off-list ref]"); MODULE_DESCRIPTION("PMGR power state driver for Apple SoCs"); -MODULE_LICENSE("GPL v2"); module_platform_driver(apple_pmgr_ps_driver); -- 2.39.1.268.g9de2f9a303