Re: [PATCH 8/8] kbuild, PCI: microchip: comment out MODULE_LICENSE in non-modules

On 12 Feb 2023, Leon Romanovsky uttered the following:

On Fri, Feb 10, 2023 at 08:10:43PM +0000, Conor Dooley wrote:

quoted

On Fri, Feb 10, 2023 at 07:26:38PM +0000, Nick Alcock wrote:

quoted

On 10 Feb 2023, Conor Dooley said:

quoted

FYI $subject seems wrong, this is a PCI patch AFAICT.

<...>

quoted

quoted

kbuild is present in every patch in the series because this is a
kbuild-driven change (the thing it disturbs is part of the build system,
the construction of modules.builtin*). This seems to be common practice
for kbuild-related treewide changes.

Okay, I'll take your word for it. It just looked/looks odd to me!

It looks odd to me too. Please add SPDX tag in modules which don't have
it already, instead of commenting code.

OK, I now have two votes for removal-and-SPDX (you and Luis) and nobody
suggesting that keeping it in but commented out is actually a good idea:
I'll respin with removals instead, and add SPDX to anything so adjusted
that doesn't already have it (if anything).

(I'll stick both the removal and addition in the same commit, so there
is no point at which such files have no declared license at all.)

-- 
NULL && (void)