Re: [PATCH v9 1/8] kbuild: bring back tristate.conf
From: Luis Chamberlain <mcgrof@kernel.org>
Date: 2022-11-10 03:56:14
Also in:
lkml
From: Luis Chamberlain <mcgrof@kernel.org>
Date: 2022-11-10 03:56:14
Also in:
lkml
On Wed, Nov 09, 2022 at 01:41:25PM +0000, Nick Alcock wrote:
tristate.conf was dropped because it is not needed to build a modules.builtin (although dropping it introduces a few false positives into modules.builtin support), and doing so avoids one round of recursion through the build tree to build it. But kallmodsyms support requires building a mapping from object file name to built-in module name for all builtin modules: this seems to me impossible to accomplish without parsing all makefiles under the influence of tristate.conf, since the makefiles are the only place this mapping is recorded. So bring it back for this purpose. (Thanks to the refactoring in the 5.16 timeframe, this is basically a reimplementation of commit 8b41fc4454e36fbfdbb23f940d023d4dece2de29 rather than a simple reversion.) Signed-off-by: Nick Alcock <redacted> Reviewed-by: Victor Erminpour <redacted> Reviewed-by: Kris Van Hees <redacted>
I don't see the need, see the review of next patch. Luis