On Wed, Jul 20, 2022 at 1:57 AM Luis Chamberlain [off-list ref] wrote:

On Wed, Jul 13, 2022 at 08:52:20AM +0800, David Gow wrote:

quoted

The new KUnit module handling has KUnit test suites listed in a
.kunit_test_suites section of each module. This should be loaded when
the module is, but at the moment this only happens if KUnit is built-in.

This commit log does not describe what functionality is broken exactly
without this commit. What functionality from kunit is provided when
.kunit_test_suites is available?

Sorry: the explanation is a bit obtuse, I admit.

Basically, when kunit itself is built as a module, no tests run. This
is because the code to load the .kunit_test_suites section is compiled
out if kunit is not built-in, but it should be present even if kunit
is built as a module.

quoted

Also load this when KUnit is enabled as a module: it'll not be usable
unless KUnit is loaded,

What benefit is there to load a kunit module without kunit?

None whatsoever, and it should be impossible. This was just rationale
for the overhead of loading the section being likely insignificant,
but it's worded pretty poorly.

quoted

but such modules are likely to depend on KUnit
anyway, so it's unlikely to ever be loaded needlessly.

Fixes: 3d6e44623841 ("kunit: unify module and builtin suite definitions")
Signed-off-by: David Gow <redacted>

I'll update the commit message when I send a new version of this out.

Cheers,
-- David