Thread (6 messages) 6 messages, 3 authors, 2022-07-11

Re: [PATCH v2] module: kallsyms: Ensure preemption in add_kallsyms() with PREEMPT_RT

From: Aaron Tomlin <atomlin@atomlin.com>
Date: 2022-07-07 18:58:47
Also in: linux-rt-users, lkml

On Thu 2022-07-07 10:20 -0700, Luis Chamberlain wrote:
This is incredibly important information which should be added to the
commit log, specialy as PREEMPT_RT=y becomes a first class citizen.
Understood.
quoted
So, I would say this was a regression since earlier preemption was
not disabled and we would dereference RCU-protected pointers explicitly
i.e. without using the more appropriate rcu_dereference() family
of primitives. That being said, these pointers cannot change in this
context as explained previously.

Would the above be suitable - just to confirm before I send another
iteration?
Yes, I would send this to Linus for the rc series. Please adjust the
commit log with all this information.
Will do.
BTW I think there is just one more fix pending from you right?
Yes - I will send/or prepare it as a partial revert:
's/strscpy/strlcpy/' with a brief explanation.


Kind regards,

-- 
Aaron Tomlin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help