Thread (32 messages) 32 messages, 5 authors, 2022-07-03

Re: [PATCH v11 09/14] module: Move kallsyms support into a separate file

From: Christophe Leroy <hidden>
Date: 2022-07-03 17:58:28
Also in: lkml


Le 03/07/2022 à 16:13, Steven Rostedt a écrit :
On Sun, 3 Jul 2022 14:57:08 +0100
Aaron Tomlin [off-list ref] wrote:
quoted
Hi Steve,

I completely agree and noted.
quoted
You even stated "no functional change" which was a lie. Converting
strlcpy() to strscpy() *is* a functional change!
Understood.
Sorry about being harsh. It's something that was engrained in me when
doing kernel development, and something I found useful for all software
development.

Honestly, the hardest thing about kernel development is the review
process. The easier we can make reviewing, the better the code will be.
I'm probably the one who misleaded Aaron.

When I started submitting Kernel patches years ago, I was given those 
guidelines:
- Always submit checkpatch clean patches.
- Try to never modify the same line of code twice in a series.

Which implied to always fix codying Style while changing or moving code.

Christophe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help