Re: [PATCH 1/2] module: Fix ERRORs reported by checkpatch.pl
From: Joe Perches <joe@perches.com>
Date: 2022-06-12 19:36:05
Also in:
lkml
On Sun, 2022-06-12 at 19:44 +0200, Christophe Leroy wrote:
Checkpatch reports following errors:
There are many conditions that checkpatch reports that do not need fixing. checkpatch is a mindless script. It's not always right.
Signed-off-by: Christophe Leroy <redacted>
[]
quoted hunk ↗ jump to hunk
diff --git a/kernel/module/main.c b/kernel/module/main.c
[]
quoted hunk ↗ jump to hunk
@@ -1111,9 +1111,9 @@ resolve_symbol_wait(struct module *mod, const struct kernel_symbol *ksym; char owner[MODULE_NAME_LEN]; + ksym = resolve_symbol(mod, info, name, owner); if (wait_event_interruptible_timeout(module_wq,
Did you verify this change by looking at the code for wait_event_interruptible_timeout?
- !IS_ERR(ksym = resolve_symbol(mod, info, name, owner))
- || PTR_ERR(ksym) != -EBUSY,
+ !IS_ERR(ksym) || PTR_ERR(ksym) != -EBUSY,
30 * HZ) <= 0) {
pr_warn("%s: gave up waiting for init of module %s.\n",
mod->name, owner);