Thread (22 messages) 22 messages, 4 authors, 2022-02-11

Re: [PATCH v5 01/13] module: Move all into module/

From: Aaron Tomlin <hidden>
Date: 2022-02-10 14:46:02
Also in: live-patching, lkml

On Thu 2022-02-10 11:11 +0000, Christophe Leroy wrote:
quoted
diff --git a/MAINTAINERS b/MAINTAINERS
index 3e461db9cd91..7e6232bd15f5 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -13001,7 +13001,7 @@ L:    linux-kernel@vger.kernel.org
  S:    Maintained
  T:    git git://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git modules-next
  F:    include/linux/module.h
-F:    kernel/module.c
+F:    kernel/module/main.c
Shouldn't it be the entire directory ?
Firstly, thank you for your feedback Christophe.

Indeed it should. Moving forward: kernel/module/*
quoted
@@ -44,6 +44,7 @@ static inline int module_decompress(struct load_info *info,
  {
      return -EOPNOTSUPP;
  }
+
This new line should be in patch 3 instead.
Fair enough. Given that the purpose of this particular patch is a simple
migration, style violations e.g. "Please use a blank line after
function/struct/union/enum declarations", can be resolved at a later stage.


Kind regards,

-- 
Aaron Tomlin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help