Re: [PATCH 2/2] depmod: just add .bin suffix to builtin.modinfo
From: Alexey Gladkov <hidden>
Date: 2020-03-06 09:58:29
On Thu, Mar 05, 2020 at 11:59:34PM -0800, Lucas De Marchi wrote:
quoted hunk ↗ jump to hunk
For all the other indexes what we do is to add a .bin to the original filename to denote it's the indexed version of that file. It was kernel's decision to name it modules.builtin.modinfo, so respect that. Fix: b866b2165ae6 ("Lookup aliases in the modules.builtin.modinfo") --- tools/depmod.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/tools/depmod.c b/tools/depmod.c index 875e314..fe1c54d 100644 --- a/tools/depmod.c +++ b/tools/depmod.c@@ -2402,7 +2402,7 @@ static int output_devname(struct depmod *depmod, FILE *out) return 0; } -static int output_builtin_alias_bin(struct depmod *depmod, FILE *out) +static int output_builtin_modinfo_bin(struct depmod *depmod, FILE *out) { int ret = 0, count = 0; struct index_node *idx;@@ -2482,7 +2482,7 @@ static int depmod_output(struct depmod *depmod, FILE *out) { "modules.symbols", output_symbols }, { "modules.symbols.bin", output_symbols_bin }, { "modules.builtin.bin", output_builtin_bin }, - { "modules.builtin.alias.bin", output_builtin_alias_bin }, + { "modules.builtin.modinfo.bin", output_builtin_modinfo_bin },
This file does not contain all whole modinfo. Now the function name and index name will be confusing. But it's up to you.
{ "modules.devname", output_devname },
{ }
};
--
2.25.1-- Rgrds, legion