Re: [PATCH] depmod: account for new namespace field in Module.symvers (for kernel versions >= 5.4)
From: Jessica Yu <jeyu@kernel.org>
Date: 2020-03-04 09:18:38
From: Jessica Yu <jeyu@kernel.org>
Date: 2020-03-04 09:18:38
+++ Lucas De Marchi [03/03/20 22:28 -0800]:On Fri, Feb 21, 2020 at 8:53 AM Jessica Yu [off-list ref] wrote:quoted
depmod -e -E is broken for kernel versions >= 5.4, because a new namespace field was added to Module.symvers. Each line is tab delimited with 5 fields in total. E.g., 0xb352177e\tfind_first_bit\tnamespace\tvmlinux\tEXPORT_SYMBOL When a symbol doesn't have a namespace, then the namespace field is empty: 0xb352177e\tfind_first_bit\t\tvmlinux\tEXPORT_SYMBOLWhy is namespace added in the *middle*? We remember we specifically talked about compatibility back when this was added. Why is it not at the end so tools that don't know about namespace don't stop working? Lucas De Marchi
Sigh, I do remember we had a short discussion upstream back in August [1] when we were tossing around Module.symvers format preferences. It is my fault for not having pushed the backwards compatibility option more instead of thinking it could be patched up in kmod tools. I think maybe the best course of option is to revert this upstream instead and Cc:stable. Sorry about this. :-/ [1] https://lore.kernel.org/r/20190828094325.GA25048@linux-8ccs (local)