Re: [Cocci] [PATCH v2 08/10] scripts: Coccinelle script for namespace dependencies.
From: Matthias Maennich <maennich@google.com>
Date: 2019-08-14 08:03:18
Also in:
cocci, linux-arch, linux-kbuild, linux-m68k, linux-scsi, linux-usb, lkml
On Wed, Aug 14, 2019 at 12:06:11PM +0530, Himanshu Jha wrote:
On Tue, Aug 13, 2019 at 01:17:05PM +0100, Matthias Maennich wrote:quoted
A script that uses the '<module>.ns_deps' file generated by modpost to automatically add the required symbol namespace dependencies to each module. Usage: 1) Move some symbols to a namespace with EXPORT_SYMBOL_NS() or define DEFAULT_SYMBOL_NAMESPACE 2) Run 'make' (or 'make modules') and get warnings about modules not importing that namespace. 3) Run 'make nsdeps' to automatically add required import statements to said modules. This makes it easer for subsystem maintainers to introduce and maintain symbol namespaces into their codebase. Co-developed-by: Martijn Coenen <redacted> Signed-off-by: Martijn Coenen <redacted> Signed-off-by: Matthias Maennich <maennich@google.com> ---[]quoted
MAINTAINERS | 5 ++ Makefile | 12 +++++ scripts/Makefile.modpost | 4 +- scripts/coccinelle/misc/add_namespace.cocci | 23 +++++++++ scripts/nsdeps | 54 +++++++++++++++++++++ 5 files changed, 97 insertions(+), 1 deletion(-) create mode 100644 scripts/coccinelle/misc/add_namespace.cocci create mode 100644 scripts/nsdeps[]quoted
+if [ "$SPATCH_VERSION_NUM" -lt "$SPATCH_REQ_VERSION_NUM" ] ; then + echo 'spatch needs to be version 1.06 or higher'Nitpick: 1.0.6
Good catch! Thanks! Actually it needs to be even 1.0.4, so I will just use $SPATCH_REQ_VERSION from above.
quoted
+ exit 1 +fi-- Himanshu Jha Undergraduate Student Department of Electronics & Communication Guru Tegh Bahadur Institute of Technology