Thread (2 messages) 2 messages, 2 authors, 2018-07-18
STALE2994d

[PATCH] libkmod: drop _PAD enum constants

From: Jan Engelhardt <hidden>
Date: 2018-07-18 09:20:31
Subsystem: the rest · Maintainer: Linus Torvalds

When are enums ever mapped to something smaller than int, other than
willful packing into a bitfield?
---
 libkmod/libkmod.h | 4 ----
 1 file changed, 4 deletions(-)
diff --git a/libkmod/libkmod.h b/libkmod/libkmod.h
index 352627e..4fb5ba8 100644
--- a/libkmod/libkmod.h
+++ b/libkmod/libkmod.h
@@ -71,8 +71,6 @@ enum kmod_index {
 	KMOD_INDEX_MODULES_ALIAS,
 	KMOD_INDEX_MODULES_SYMBOL,
 	KMOD_INDEX_MODULES_BUILTIN,
-	/* Padding to make sure enum is not mapped to char */
-	_KMOD_INDEX_PAD = 1U << 31,
 };
 int kmod_dump_index(struct kmod_ctx *ctx, enum kmod_index type, int fd);
 
@@ -210,8 +208,6 @@ enum kmod_module_initstate {
 	KMOD_MODULE_LIVE,
 	KMOD_MODULE_COMING,
 	KMOD_MODULE_GOING,
-	/* Padding to make sure enum is not mapped to char */
-	_KMOD_MODULE_PAD = 1U << 31,
 };
 const char *kmod_module_initstate_str(enum kmod_module_initstate state);
 int kmod_module_get_initstate(const struct kmod_module *mod);
-- 
2.18.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help