Hi, Michal!

(Leaving in Cc only the list and maintainer)

quoted

quoted

quoted

quoted

On Tue, 13 Mar 2018 10:57:39 +0100, Michal Suchánek  wrote:

 > On Mon, 12 Mar 2018 22:41:19 +0200
 > Yauheni Kaliuta [off-list ref] wrote:

 >> Hi, Michal!
 >> 
 >> >>>>> On Thu,  8 Mar 2018 19:14:26 +0100, Michal Suchanek  wrote:  
 >> 
 >> > The mod_sig is allocated on stack and when no signature is present
 >> > it is not initialized and contains garbage. Later when freeing
 >> > mod_sig garbage pointer is dereferenced.  
 >> 
 >> I guess, it is enough to init the structure.

 > Yes, it is enough to initialize the structure. However, this issue is
 > caused by the awkward interface to the kmod_module_signature_info
 > function so changing the interface should prevent such errors in the
 > future.

Frankly, I made the same change of the interface in my initial
implementation before the functionality :) But it's up to Lucas, I guess,
you can send the patch on top of the master already now ready for
applying.

-- 
WBR,
Yauheni Kaliuta