On Wed, Jun 7, 2017 at 5:00 AM, Joel Stanley [off-list ref] wrote:

On Wed, Jun 7, 2017 at 3:48 PM, Joel Stanley [off-list ref] wrote:

quoted

In commit a6ede6c7ad46 (util: fix warning of equal values on logical OR)
the runtime check for EAGAIN and EWOULDBLOCK being equal was converted
into an assert.

For the case where the compiler supports _Static_assert, this is can be
called staticly. However the fallback for older compilers uses a
non-static test that needs to be called from a function context.

Move the assert into the functions that used to have the runtime check.
The test does not add any runtime overhead, so it is fine to duplicate
it.

Tested with and without HAVE_STATIC_ASSERT defined using GCC 6.3.

Signed-off-by: Joel Stanley <joel@jms.id.au>

I just saw the git history and noticed that Thomas sent a patch fixing
this already. Excellent! Sorry for the noise.

So many people using ancient compilers... I must be missing the fun :)

Lucas De Marchi