Re: [PATCH kmod 3/3] tools: display features together with version information
From: Lucas De Marchi <hidden>
Date: 2015-06-09 01:42:37
Also in:
lkml
From: Lucas De Marchi <hidden>
Date: 2015-06-09 01:42:37
Also in:
lkml
On Sun, Jun 7, 2015 at 6:17 AM, Andreas Mohr [off-list ref] wrote:
Hi, On Sun, Jun 07, 2015 at 03:27:29AM -0300, lucas.de.marchi@gmail.com wrote:quoted
From: Lucas De Marchi <redacted>diff --git a/tools/kmod.c b/tools/kmod.c index c9d2cc8..28217df 100644 --- a/tools/kmod.c +++ b/tools/kmod.c@@ -114,6 +114,7 @@ static int handle_kmod_commands(int argc, char *argv[]) return EXIT_SUCCESS; case 'V': puts("kmod version " VERSION); + puts(KMOD_FEATURES); return EXIT_SUCCESS;Hmm - seems kmod.c is the only component which open-codes literals rather than making use of PACKAGE define? If this is not intended, then it would probably be useful to have another correction commit prior to this one included in the series, to have this one gain properly fully symmetric content.
Indeed. I just added a commit doing that and pushed to master. thanks -- Lucas De Marchi