On Mon, 22 Jun 2015 11:30:40 -0300
Lucas De Marchi [off-list ref] wrote:

On Mon, Jun 22, 2015 at 11:20 AM, Lucas De Marchi
[off-list ref] wrote:

quoted

Hi,

On Mon, Jun 22, 2015 at 9:09 AM, Natanael Copa [off-list ref] wrote:

quoted

Use POSIX Extended Regular Expression (ERE) instead of the GNU extension
\| in the install-exec-hook. This makes it create the symlink properly
with busybox sed built with musl libc. It will silently create a broken
symlink otherwise.

Oh... so you are running "make install" in a system with only busybox
built with musl? :-o

yes. i think i have built 1000+ packages with busybox sed only.

quoted

Anyway, this change seems sane enough so it's applied.

when pushing the CI alerted me it was failing.

        Makefile.am:111: error: blank line following trailing backslash

I fixed this up myself, but now I'm wondering if this has been at
least compile-tested.

My bad. sorry about that.

I did "unit" test it, eg copy paste and tested that the sed line worked
with both GNU sed and busybox sed.

I have now also compile and make install tested it. It works as
expected after removing the blank line.


ncopa-desktop:~/src/kmod$ ls -l /tmp/kmod/lib/
total 448
lrwxrwxrwx 1 ncopa ncopa     17 Jun 23 13:52 libkmod.so.2 -> libkmod.so.2.2.11
-rwxr-xr-x 1 ncopa ncopa 454880 Jun 23 13:52 libkmod.so.2.2.11
ncopa-desktop:~/src/kmod$ ls -l /tmp/kmod/usr/lib/
total 8
-rwxr-xr-x 1 ncopa ncopa  903 Jun 23 13:52 libkmod.la
lrwxrwxrwx 1 ncopa ncopa   27 Jun 23 13:52 libkmod.so -> ../../lib/libkmod.so.2.2.11
drwxr-xr-x 2 ncopa ncopa 4096 Jun 23 13:52 pkgconfig

Thanks!

-nc