Thread (4 messages) 4 messages, 2 authors, 2015-03-11

Re: [PATCH] build: generate libkmod.pc during autoconf

From: Jeff Waugh <hidden>
Date: 2015-03-11 00:30:45

Hi Lucas,

On Wed, Mar 11, 2015 at 4:04 AM, Lucas De Marchi
[off-list ref] wrote:
what exactly are you solving here? What's the problem with doing it
during make not during configure?

It certainly affects cross-compiling. Possibly other stuff.


Here's the relevant part of libkmod.pc when produced during make:

prefix=/usr
exec_prefix=/usr
libdir=/usr/lib
includedir=/usr/include


And during configure:

prefix=/usr
exec_prefix=/usr
libdir=${exec_prefix}/lib
includedir=${prefix}/include

quoted
like other packages do. (Patch from OpenWrt's contributed packages project.)
others do like we do, too:
https://git.kernel.org/cgit/linux/kernel/git/kay/libabc.git/tree/Makefile.am
http://cgit.freedesktop.org/systemd/systemd/tree/Makefile.am

should they be changed, too?

Yes! I was just about to send a fix for systemd, as that burned me too. :-)

(If you check any of the libraries on git.gnome.org, their pkg-config
files are generated during configure.)

Thanks,
Jeff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help