Thread (13 messages) 13 messages, 2 authors, 2014-02-28

Re: [PATCH 0/5] kmod_module_insert_module() cleanup and test coverage

From: Michal Marek <hidden>
Date: 2014-02-28 06:42:01

Dne 28.2.2014 07:03, Lucas De Marchi napsal(a):
Hi Michal,

On Thu, Feb 27, 2014 at 7:52 PM, Michal Marek [off-list ref] wrote:
quoted
I only wanted to send the kmod_module_insert_module() patch after passing
the testsuite, but then I noticed the testsuite is hardly testing it :).

Michal

Michal Marek (5):
  testsuite: Check the list of loaded modules after a test
  testsuite: Add test for modprobe --force
  testsuite: Do not provide finit_module(2) on older kernels
  Add some tests for kernels without finit_module(2)
  libkmod-module: Simplify kmod_module_insert_module()
It's pretty good. Thanks.

I only have some cosmetic comments. I can make the changes when
applying if you prefer. See in the individual patches.
I will resend an updated series. Thanks a lot for the review!

Michal
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help