Re: [PATCH 2/2] mmc: meson-mx-sdio: add IRQ check
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Date: 2021-12-18 23:23:25
Also in:
linux-amlogic, linux-arm-kernel
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Date: 2021-12-18 23:23:25
Also in:
linux-amlogic, linux-arm-kernel
On Fri, Dec 17, 2021 at 9:27 PM Sergey Shtylyov [off-list ref] wrote:
The driver neglects to check the result of platform_get_irq()'s call and
blithely passes the negative error codes to devm_request_threaded_irq()
(which takes *unsigned* IRQ #), causing it to fail with -EINVAL, overriding
an original error code. Stop calling devm_request_threaded_irq() with the
invalid IRQ #s.
Fixes: ed80a13bb4c4 ("mmc: meson-mx-sdio: Add a driver for the Amlogic Meson8 and Meson8b SoC")
Signed-off-by: Sergey Shtylyov <redacted>Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Thank you for catching this and for submitting a fix!