Re: [PATCH 2/6] dt-bindings: mmc: cdns: match MPFS MMC/SDHCI controller
From: Rob Herring <robh@kernel.org>
Date: 2021-08-24 14:33:55
Also in:
linux-devicetree, linux-riscv, lkml
On Thu, Aug 19, 2021 at 05:44:32PM +0200, Krzysztof Kozlowski wrote:
The Microchip MPFS Icicle Kit uses Cadence SD/SDIO/eMMC Host Controller without any additional vendor compatible:
I think the lack of vendor compatible is the error here. Experience has shown that vendor specific compatibles are needed for licensed IP.
quoted hunk ↗ jump to hunk
arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dt.yaml: mmc@20008000: compatible:0: 'cdns,sd4hc' is not one of ['socionext,uniphier-sd4hc'] arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dt.yaml: mmc@20008000: compatible: ['cdns,sd4hc'] is too short Signed-off-by: Krzysztof Kozlowski <redacted> --- Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)diff --git a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml b/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml index af7442f73881..0489aa92cb54 100644 --- a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml +++ b/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml@@ -15,9 +15,11 @@ allOf: properties: compatible: - items: - - enum: - - socionext,uniphier-sd4hc + oneOf: + - items: + - enum: + - socionext,uniphier-sd4hc + - const: cdns,sd4hc - const: cdns,sd4hc reg:-- 2.30.2