Re: [PATCH 09/30] mtd_blkdevs: use blk_mq_alloc_disk
From: Marek Szyprowski <m.szyprowski@samsung.com>
Date: 2021-06-15 16:29:00
Also in:
ceph-devel, dm-devel, linux-block, linux-s390, linuxppc-dev, xen-devel
Hi Christoph, On 15.06.2021 17:58, Christoph Hellwig wrote:
quoted hunk ↗ jump to hunk
On Tue, Jun 15, 2021 at 05:47:44PM +0200, Marek Szyprowski wrote:quoted
On 02.06.2021 08:53, Christoph Hellwig wrote:quoted
Use the blk_mq_alloc_disk API to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig <hch@lst.de>This patch landed in linux-next as commit 6966bb921def ("mtd_blkdevs: use blk_mq_alloc_disk"). It causes the following regression on my QEMU arm64 setup:Please try the patch below:diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c index 5dc4c966ea73..6ce4bc57f919 100644 --- a/drivers/mtd/mtd_blkdevs.c +++ b/drivers/mtd/mtd_blkdevs.c@@ -382,6 +382,7 @@ int add_mtd_blktrans_dev(struct mtd_blktrans_dev *new) } new->disk = gd; + new->rq = new->disk->queue; gd->private_data = new; gd->major = tr->major; gd->first_minor = (new->devnum) << tr->part_bits;
Right, this fixes the issue, thanks. Feel free to add: Reported-by: Marek Szyprowski <m.szyprowski@samsung.com> Tested-by: Marek Szyprowski <m.szyprowski@samsung.com> Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland