Re: [PATCH 1/1] mmc: usdhi6rol0: fix error return code in usdhi6_probe()
From: Ulf Hansson <hidden>
Date: 2021-05-11 10:57:40
Also in:
lkml
On Sat, 8 May 2021 at 04:04, Zhen Lei [off-list ref] wrote:
Fix to return a negative error code from the error handling case instead
of 0, as done elsewhere in this function.
Fixes: 75fa9ea6e3c0 ("mmc: add a driver for the Renesas usdhi6rol0 SD/SDIO host controller")
Reported-by: Hulk Robot <redacted>
Signed-off-by: Zhen Lei <redacted>Applied for next, thanks! Kind regards Uffe
quoted hunk ↗ jump to hunk
--- drivers/mmc/host/usdhi6rol0.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/mmc/host/usdhi6rol0.c b/drivers/mmc/host/usdhi6rol0.c index 615f3d008af1..b9b79b1089a0 100644 --- a/drivers/mmc/host/usdhi6rol0.c +++ b/drivers/mmc/host/usdhi6rol0.c@@ -1801,6 +1801,7 @@ static int usdhi6_probe(struct platform_device *pdev) version = usdhi6_read(host, USDHI6_VERSION); if ((version & 0xfff) != 0xa0d) { + ret = -EPERM; dev_err(dev, "Version not recognized %x\n", version); goto e_clk_off; } --2.25.1