Thread (5 messages) 5 messages, 5 authors, 2021-01-25

Re: [PATCH] mmc: sdhci-brcmstb: Fix mmc timeout errors on S5 suspend

From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2021-01-07 22:43:30
Also in: linux-arm-kernel, lkml

On 1/7/21 2:15 PM, Al Cooper wrote:
Commit e7b5d63a82fe ("mmc: sdhci-brcmstb: Add shutdown callback")
that added a shutdown callback to the diver, is causing "mmc timeout"
errors on S5 suspend. The problem was that the "remove" was queuing
additional MMC commands after the "shutdown" and these caused
timeouts as the MMC queues were cleaned up for "remove". The
shutdown callback will be changed to calling sdhci-pltfm_suspend
which should get better power savings because the clocks will be
shutdown.

Fixes: e7b5d63a82fe ("mmc: sdhci-brcmstb: Add shutdown callback")
Signed-off-by: Al Cooper <alcooperx@gmail.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help