Re: [PATCH v5 01/12] clk: apn806: Add eMMC clock to system controller driver
From: Stephen Boyd <hidden>
Date: 2017-01-21 00:18:31
Also in:
linux-arm-kernel, linux-clk, linux-devicetree, lkml
On 01/11, Gregory CLEMENT wrote:
From: Konstantin Porotchkin <redacted> Add fixed clock of 400MHz to system controller driver. This clock is used as SD/eMMC clock source. Signed-off-by: Konstantin Porotchkin <redacted> Reviewed-by: Omri Itach <redacted> Reviewed-by: Hanna Hawa <redacted> [fixed up conflicts, added error handling --rmk] Signed-off-by: Russell King <redacted> Signed-off-by: Gregory CLEMENT <redacted> ---
Acked-by: Stephen Boyd <redacted>
quoted hunk ↗ jump to hunk
diff --git a/drivers/clk/mvebu/ap806-system-controller.c b/drivers/clk/mvebu/ap806-system-controller.c index 8181b919f062..0a785076b0c6 100644 --- a/drivers/clk/mvebu/ap806-system-controller.c +++ b/drivers/clk/mvebu/ap806-system-controller.c@@ -117,6 +117,17 @@ static int ap806_syscon_clk_probe(struct platform_device *pdev) goto fail3; } + /* eMMC Clock is fixed clock divided by 3 */ + of_property_read_string_index(np, "clock-output-names", + 4, &name);
This could check for failure and not register the clk if the name isn't there? Then dts can be backwards compatible. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project